You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reduce AdvancedCore shaded JAR without removing embedded transport APIs - #385
The non-multi-release shaded JAR includes unused versioned resources, compile-time annotations and redundant module and Maven metadata. Filter those entries while retaining the Redis/MQTT/HTTP APIs, runtime libraries, service descriptors and licenses. Maven Shade minimization remains disabled. Consumers compiling directly against the excluded annotation types must declare their separate annotation dependency.
The JAR dropped from 6,991,512 to 6,673,681 bytes, saving 317,831 bytes (4.55%). Hosted Maven validated head 1ef438a2 with 1,723 unit tests passed and two packaged-artifact checks passed. There were zero failures or errors. Build log
The coordinated VotingPlugin build with this branch and SimpleAPI #124 also passed; live-server acceptance remains separate. Coordinated CI
Summary by CodeRabbit
Improvements
The packaged artifact excludes unnecessary versioned code, module metadata, and dependency documentation while retaining required runtime components.
Documentation
Added details about packaged contents, size filtering, and artifact validation, including the limits of automated packaging tests.
No actionable comments were generated in the recent review.
Walkthrough
The shaded JAR configuration now excludes selected multi-release, module, annotation, and Maven metadata entries. Packaging tests check required classes and excluded entries. Documentation describes the filtering rules and packaging test limits.
Changes: Shaded JAR Filtering
Layer / File(s)
Summary
Configure and verify shaded JAR contents AdvancedCore/pom.xml, AdvancedCore/src/test/java/com/bencodez/advancedcore/tests/packaging/PackagedArtifactTest.java, docs/jar-packaging.md
The Shade Plugin excludes selected multi-release, module, annotation, and Maven metadata entries. The packaging test checks required classes and filtered content. The documentation describes the filtering rules and test limits.
This change trims metadata and compile-only annotation classes from the shaded JAR while keeping the embedded transport APIs. No concrete problem was found, so merge risk is minimal. Downstream validation is still pending in CI.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title states the main change: the AdvancedCore shaded JAR is reduced in size while embedded transport APIs (Redis, MQTT, HTTP TLS) are kept. The raw summary confirms the shade plugin exclusions, t…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check
Explanation
The title states the main change: the AdvancedCore shaded JAR is reduced in size while embedded transport APIs (Redis, MQTT, HTTP TLS) are kept. The raw summary confirms the shade plugin exclusions, the packaged-artifact tests, and the docs describe that trade-off. The title is specific and matches the changeset.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
OSV Scanner (2.7.0)
AdvancedCore/pom.xml
OSV Scanner exited with code 127; dependency analysis is incomplete
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Recent review details
Context from checks skipped due to timeout: 4
GitHub Check: CodeRabbit
GitHub Check: build
GitHub Check: Analyze (java-kotlin)
GitHub Check: Analyze (actions)
Additional context used
Code guidelines: 1
AGENTS.md — auto-discovered
Path-based instructions: 1
Source excerpt: All test classes and test-only helpers must live under `com.bencodez.advancedcore.tests` or its subpackages, with matching directories under `AdvancedCore/src/test/java`.
Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-multi-release shaded JAR includes unused versioned resources, compile-time annotations and redundant module and Maven metadata. Filter those entries while retaining the Redis/MQTT/HTTP APIs, runtime libraries, service descriptors and licenses. Maven Shade minimization remains disabled. Consumers compiling directly against the excluded annotation types must declare their separate annotation dependency.
The JAR dropped from 6,991,512 to 6,673,681 bytes, saving 317,831 bytes (4.55%). Hosted Maven validated head
1ef438a2with 1,723 unit tests passed and two packaged-artifact checks passed. There were zero failures or errors. Build logThe coordinated VotingPlugin build with this branch and SimpleAPI #124 also passed; live-server acceptance remains separate. Coordinated CI
Summary by CodeRabbit